🌱 Revert "perf.: run integration tests only on approved PRs (#2609)" #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerschrock
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
|
Since integration tests are required and currently broken, they will need to be marked as a not required check to get this merged in. |
spencerschrock
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2612 +/- ##
=======================================
Coverage 40.40% 40.40%
=======================================
Files 122 122
Lines 9908 9908
=======================================
Hits 4003 4003
Misses 5624 5624
Partials 281 281 |
naveensrinivasan
approved these changes
Jan 23, 2023
naveensrinivasan
approved these changes
Jan 23, 2023
This reverts commit a29182d. Signed-off-by: Spencer Schrock <sschrock@google.com>
naveensrinivasan
force-pushed
the
revert-2609-main
branch
from
2033887
to
aad61db
Compare
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Feb 9, 2023
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix for infra
What is the current behavior?
Reverts #2609
pull_request_reviewdoesn't have access to secrets, so the e2e tests are failinghttps://github.com/ossf/scorecard/actions/runs/3989324836
What is the new behavior (if this is a feature change)?**
should work as before
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)